This repository was archived by the owner on Dec 2, 2017. It is now read-only.
Better exception handling/logging#13
Open
tonyc wants to merge 3 commits intolook:masterfrom
tonyc:master
Open
Conversation
added 3 commits
May 11, 2011 17:14
…may be stubbed. create or use a logger object, and expose through a method as well. explicitly catch exceptions and log them to this logger, rather than swallowing them
Author
|
Just queued up another pull request for when I get to it |
|
I'd like to 2nd this request. I'm currently stuck in a loop somewhere, and having a heck of a time finding out where. There is no email to be processed to my knowledge, but fetcher seems to be pulling emails previously processed.... I can't find them either.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a few things going on in this commit.
The first was to refactor the fetchers to use a connection() method to make everything a bit easier to test.
The other is to specify the exception caught, and to log the error and backtrace to either the provided logger, Rails.logger (if it's there), or a stdlib Logger object.